Fix folder import with domain containing special characters #6915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-susanh
approved these changes
Aug 11, 2025
| { | ||
| String tableName = expObject.getName(); | ||
| // tsv file name will have been generated from a sanitized table name | ||
| // tsv file name might have been generated from a sanitized table name |
Contributor
There was a problem hiding this comment.
Perhaps add a note that the uncertainly comes from different treatment in the folder export/import case.
Contributor
Author
There was a problem hiding this comment.
I just pushed a change with a different implementation.
Contributor
|
Please update PR details with rationale and list of changes. |
This was referenced Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
When a domain name ends with a dot (.) character, FiltUtil.makeLegalName would convert that . to _ when trying to match its import file during folder import. The conversion of dot to _ only happens when the dot is the last character in the filename. The logic is flawed in that it doesn't take into the ".tsv" suffix, which would mean the dot is in fact not the last character in the filename.
Related Pull Requests
Changes
FileUtil.makeLegalNameto get the correct file name.